Repository navigation
ci: skip registry login and push on pull_request events - #18
Merged
Merged
Conversation
Dependabot PRs cannot read repo secrets, so docker/login-action failed with 'Password required'. Guard all credential/login steps with 'if: github.event_name != pull_request' and make buildx push only on branch pushes (build-only via cacheonly on PRs) so PRs still validate that the Dockerfiles build.
skunxicat
added a commit
that referenced
this pull request
Oct 24, 2026
…#20) The Build and Release workflow runs on every PR (no paths filter) and its build-base job logged into GHCR and Public ECR unconditionally, so Dependabot PRs failed with 'Password required' before any build ran. Guard all login/credential steps in both the build-base and build jobs with 'if: github.event_name != pull_request', and make build-base push only on branch pushes (cacheonly on PRs). The build job already builds --load without pushing on PRs. Mirrors the fix applied to build-base.yml and build-installers.yml in #18.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
Build Installers/Build Base Imagejobs failing on Dependabot PRs (e.g. #17) with:Dependabot-triggered
pull_requestruns cannot read the repository secrets (GHCR_PAT,AWS_ACCESS_KEY_ID/AWS_SECRET_ACCESS_KEY) used bydocker/login-actionand the Public ECR login, so the password resolves to empty and the login step errors. Those workflows also attempted to--pushto GHCR/Public ECR, which a PR shouldn't do anyway.Changes
configure-aws-credentials, GHCR login, Public ECR login) withif: github.event_name != 'pull_request'.PUSHenv and make eachdocker buildx buildeither--push(branch pushes) or build-only (--output=type=cacheonly) on PRs.build-base.yml, provide a dummygithub_tokensecret file on PRs so the--secretmount still resolves without a push.Net effect: PRs still validate that the Dockerfiles build; only pushes to
main/developlog in and publish images.Testing