Repository navigation
Conversation
Summary: `RCTHermesInstanceFactory.h` is part of React's umbrella header, so every `import React` compiles it. It imported `<react/runtime/JSRuntimeFactoryCAPI.h>`, which the C++ stable API classifies as "for frameworks", only to get the opaque `JSRuntimeFactoryRef` handle. So an app that defines `RN_STRICT_API` gets a "for frameworks" warning from React Native's own header that it cannot act on: with the prebuilt SwiftPM artifacts the warning fires while the `React` module is built with the app's macros. Declare the handle in the header instead, the same way `RCTJSRuntimeConfiguratorProtocol.h` already does (`typedef void *JSRuntimeFactoryRef;`). The type and ABI are unchanged, and identical typedefs may be repeated in C and C++, so a translation unit that also includes `JSRuntimeFactoryCAPI.h` still compiles. Code that needs the rest of the C API, such as `js_runtime_factory_destroy`, imports `JSRuntimeFactoryCAPI.h` directly, as `RCTRootViewFactory.mm` already does. With this, no header in React's umbrella reaches a stable API guard when compiled as Objective-C. Changelog: [Internal] Differential Revision: D125448714
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
|
@coado has exported this pull request. If you are a Meta employee, you can view the originating Diff in D125448714. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
RCTHermesInstanceFactory.his part of React's umbrella header, so everyimport Reactcompiles it. It imported<react/runtime/JSRuntimeFactoryCAPI.h>, which the C++ stable API classifies as "for frameworks", only to get the opaqueJSRuntimeFactoryRefhandle. So an app that definesRN_STRICT_APIgets a "for frameworks" warning from React Native's own header that it cannot act on: with the prebuilt SwiftPM artifacts the warning fires while theReactmodule is built with the app's macros.Declare the handle in the header instead, the same way
RCTJSRuntimeConfiguratorProtocol.halready does (typedef void *JSRuntimeFactoryRef;). The type and ABI are unchanged, and identical typedefs may be repeated in C and C++, so a translation unit that also includesJSRuntimeFactoryCAPI.hstill compiles. Code that needs the rest of the C API, such asjs_runtime_factory_destroy, importsJSRuntimeFactoryCAPI.hdirectly, asRCTRootViewFactory.mmalready does.With this, no header in React's umbrella reaches a stable API guard when compiled as Objective-C.
Changelog:
[Internal]
Differential Revision: D125448714