Skip to content

Invalidate the layer when borderCurve changes on iOS - #59114

Open
tshmieldev wants to merge 1 commit into
react:mainfrom
tshmieldev:fix-ios-border-curve-invalidate
Open

tshmieldev wants to merge 1 commit into
react:mainfrom
tshmieldev:fix-ios-border-curve-invalidate

Conversation

@tshmieldev

Copy link
Copy Markdown
Contributor

Summary:

On iOS, RCTViewComponentView updateProps:oldProps: only invalidates the layer when borderStyles, borderRadii or borderColors change. A change to borderCurve alone is parsed into borderCurves but never reaches layer.cornerCurve, so the old curve stays on screen until some other border prop changes. This adds borderCurves to that comparison.

Changelog:

[IOS] [FIXED] - Apply borderCurve changes that are not accompanied by another border prop change

Test Plan:

On the iOS simulator (0.88.0-rc.4 with React Native built from source), a plain View with borderRadius: 80 and backgroundColor: 'blue', layered over a static borderCurve: 'circular' box, toggles borderCurve between circular and continuous with setState every 1.5s. Before the change the shape never changes, after it the continuous frames show the circular box outlining the corners.

Copilot AI balanced review requested due to automatic review settings October 15, 2026 14:14
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 15, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@facebook-github-tools facebook-github-tools Bot added p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team. labels Oct 15, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Software Mansion Partner: Software Mansion Partner Shared with Meta Applied via automation to indicate that an Issue or Pull Request has been shared with the team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants