Skip to content

Make AddProphecyTraitRector idempotent #806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Oct 18, 2026
Merged

Make AddProphecyTraitRector idempotent #806

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions rules/PHPUnit100/Rector/Class_/AddProphecyTraitRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,16 @@ private function shouldSkipClass(Class_ $class): bool
return true;
}

// structural check first, so the rule stays idempotent even when the class reflection is
// not yet aware of a trait added on a previous pass
foreach ($class->getTraitUses() as $traitUse) {
foreach ($traitUse->traits as $trait) {
if ($this->isName($trait, ProphecyClassName::PROPHECY_TRAIT)) {
return true;
}
}
}

$classReflection = $this->reflectionResolver->resolveClassReflection($class);
if (! $classReflection instanceof ClassReflection) {
return false;
Expand Down
Loading