Repository navigation
Create Dashboard with Sync and Health Status cards, Operational, Sync Activity and Reconciliation Metrics Cards (#11387) - #309
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
keithchong
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #309 +/- ##
==========================================
+ Coverage 11.30% 13.19% +1.88%
==========================================
Files 169 181 +12
Lines 6679 7262 +583
Branches 2235 2471 +236
==========================================
+ Hits 755 958 +203
- Misses 5923 6061 +138
- Partials 1 243 +242
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Keith Chong <kykchong@redhat.com>
6dd818a to
c3a54f8
Compare
aali309
left a comment
aali309
left a comment
There was a problem hiding this comment.
Looks good to me in general just a few follow up/NIT comments. Also should we consider sharing one Application watch between Sync + Health cards?
Thanks @keithchong
| <div> | ||
| {errorState( | ||
| t('Unable to retrieve metrics data'), | ||
| t('Error occurrend running query ono reconciliation metric: ' + promError), |
There was a problem hiding this comment.
| t('Error occurrend running query ono reconciliation metric: ' + promError), | |
| t('Error occurred running query on reconciliation metric: ' + promError), |
| <div> | ||
| {errorState( | ||
| t('Unable to retrieve applications'), | ||
| t('Error retrieving applications: ', loadError), |
There was a problem hiding this comment.
I think this won't show the error correctly, it wont treat it as text to be appended
| t('Error retrieving applications: ', loadError), | |
| t('Error retrieving applications: {{error}}', { error: String(loadError) }) |
| <div> | ||
| {errorState( | ||
| t('Unable to retrieve applications'), | ||
| t('Error retrieving applications: ', loadError), |
There was a problem hiding this comment.
Same issue here as in SyncStatusCard.
| <NamespaceBar onNamespaceChange={handleNamespaceChange} /> | ||
| <ListPageHeader title={t('GitOps Overview')} hideFavoriteButton={false}></ListPageHeader> | ||
| <ListPageBody> | ||
| <PageSection></PageSection> |
There was a problem hiding this comment.
looks like unused code? or this is intentional?
| ); | ||
| }; | ||
|
|
||
| export const getDayOfWeek = (day: number): string => { |
There was a problem hiding this comment.
missing default value for this switch
3 participants
See GITOPS-11387 for details before reviewing