Repository navigation
Preserve cached .NET SDK build dependencies - #508
Merged
Merged
Conversation
Assisted-by: Replit
Contributor
Author
|
@vlinkz it seems like dotnet has a dev dependency on node 🫠 |
moh-ahmadi
approved these changes
Oct 25, 2026
vlinkz
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The default Node override changed a build-only dependency of .NET 9/10. This invalidated cached SDKs and exposed a .NET 10 source-build failure.
What changed
Keep
dotnetCorePackagesin the original package set. All .NET SDK inputs and versions match the baseline before the Node override. Patched Node and selected-runtime tool bindings remain unchanged.The older Node dependency is build-only: the restored .NET 10 SDK runtime closure contains no Node package. This change avoids the new source build; it does not fix or diagnose its inner compiler error.
Test plan
scripts/ci_check.shpassed.Hello, World!.Rollout
Merge through the normal release process, then build the new revision. No production rerun or deployment was performed.
~ written by ⠕ Replit