Skip to content

Preserve cached .NET SDK build dependencies - #508

Merged
rahultee merged 1 commit into
mainfrom
preserve-dotnet-build-cache
Oct 25, 2026
Merged

rahultee merged 1 commit into
mainfrom
preserve-dotnet-build-cache

Conversation

@rahultee

Copy link
Copy Markdown
Contributor

Why

The default Node override changed a build-only dependency of .NET 9/10. This invalidated cached SDKs and exposed a .NET 10 source-build failure.

What changed

Keep dotnetCorePackages in the original package set. All .NET SDK inputs and versions match the baseline before the Node override. Patched Node and selected-runtime tool bindings remain unchanged.

The older Node dependency is build-only: the restored .NET 10 SDK runtime closure contains no Node package. This change avoids the new source build; it does not fix or diagnose its inner compiler error.

Test plan

  • scripts/ci_check.sh passed.
  • .NET 8/9/10 development and deployment module derivations match the baseline before the Node override.
  • The full .NET 10 deployment dependency graph matches the baseline exactly (811 derivations).
  • .NET 10 development/deployment modules built successfully using the cached SDK. A local console project restored without a remote package source and printed Hello, World!.
  • OCI and production disk dependency graphs select the baseline .NET bootstrap derivation, not the failed replacement.
  • Compared all 106 development module derivations: only .NET 9/10 changed. No Node toolchain fixes were reverted.
  • Full OCI images and production disks were not built or deployed.

Rollout

Merge through the normal release process, then build the new revision. No production rerun or deployment was performed.

  • This is fully backward and forward compatible

~ written by ⠕ Replit

@rahultee
rahultee marked this pull request as ready for review October 25, 2026 21:34
@rahultee
rahultee requested a review from a team as a code owner October 25, 2026 21:34
@rahultee
rahultee requested review from ryantm and removed request for a team October 25, 2026 21:34
@rahultee

Copy link
Copy Markdown
Contributor Author

@vlinkz it seems like dotnet has a dev dependency on node 🫠

@rahultee
rahultee requested a review from vlinkz October 25, 2026 21:35
@rahultee
rahultee merged commit 2f00643 into main Oct 25, 2026
8 of 9 checks passed
@rahultee
rahultee deleted the preserve-dotnet-build-cache branch October 25, 2026 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants