Skip to content

yarn test-commit-records is not run in CI #8972

Closed

Description

@cristianoc

Found by differential semantic drift analysis from a7721303 to b123b7c3.

What is broken

The semantic diff renderer's tests run nowhere in CI.

  • package.json L66 defines test-commit-records (node --test scripts/commitRecords.test.js scripts/recordMarkdown.test.js). No workflow, Makefile target or scripts/test.js step runs it; semantic_diff.yml only renders.
  • By contrast scripts/changelog.test.js runs in changelog.yml L31 and yarn test-release-plan in ci.yml L194.

#8908, #8929 and #8958 each extended these tests; a pull request that breaks parseRecord or the Markdown comment passes CI and shows up only as wrong pages or comments on other pull requests. Open #8962 adds another test file to the same script, still without a CI step.

Possible cause (speculation only)

A guess: the tests were added as a local command when the renderer was introduced, and the later pull requests extended them without noticing that CI does not run them.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions