Repository navigation
Send HTTP proxy authentication for empty passwords - #50
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #50 +/- ##
==========================================
+ Coverage 94.30% 94.36% +0.06%
==========================================
Files 55 55
Lines 1562 1562
==========================================
+ Hits 1473 1474 +1
+ Misses 89 88 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an HTTP proxy authenticates a username with an empty password,
Proxy.from_url("http://login:@proxy:port")silently omitsProxy-Authorizationand the proxy rejects CONNECT with 407. The HTTPBasicAuthencoder already supports that credential pair, but the request builder tests the password's truthiness before using it.Treat an explicitly empty password as configured when the username is present. Add a request-header regression and controls for ordinary passwords, absent passwords, and anonymous connections.
Validation on Python 3.12.3/Linux, using the repository's locked development dependencies:
Proxy.from_url()path authenticates and exchanges tunnel bytes.git diff --checkpasses.The TCP reproduction uses a local proxy fixture, without an external proxy service.