Repository navigation
fix(security): bump Node.js to 24.22.1 (CVE-2026-111497) - #39
Merged
Merged
Conversation
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why: the October 21, 2026 Node.js security release (CVE-2026-111497 Brotli RCE, plus CVE-2026-105482/-105483/-106069). Node 20 is EOL and gets no fixes. Moving to 24 is an approved major upgrade.
What:
mise.toml[tools] node"20""24"(still floating, so it resolves to 24.22.1 today)I re-checked the whole repo on
master(rgfornode:,.nvmrc,.node-version,.tool-versions,mise.toml,setup-node,sem-version,nodejs,engines).mise.tomlis the only Node reference. Nothing uses Node: CI (ci.yml,publish.yml) is Python/uv only, there is nopackage.json, andmake regenerate(openapi-python-client + ruff) is pure Python. This pin only affects local dev shells that use mise.Evidence
mise ls node→24.22.1 ~/repos/rootly-python/mise.toml 24;mise exec -- node -v→v24.22.1(V8 13.6.233.17-node.58, OpenSSL 3.5.9). 24.22.1 is listed on nodejs.org/dist/index.json.unittest discoverOK (1 test),import rootly_sdkOK,ruff checkall passed,ruff format --check4511 files already formatted.NODE_OPTIONS=--pending-deprecation mise exec -- make regenerateunder Node 24.22.1 succeeded in a scratch worktree (1638 files patched, ruff fix + format clean). I threw that output away because it's just spec drift.mise exec -- make testfails withNo module named 'httpx'. That's because mise'spython = "latest"(3.15.1) has no deps installed. It passes underuv run.Impact
Dev tooling only. The published
rootlywheel, CI and SDK users are unaffected. Developers using mise get Node 24.22.1 instead of the EOL Node 20.Risk
risk:low: one line, dev-tooling only, and nothing in the repo invokes Node.Rollout / rollback
Merging deploys nothing and needs no release. Developers run
mise installto pick it up. To roll back, revert this commit (Node 20 is EOL and vulnerable, so roll back only briefly).Link to Devin session: https://rootly.devinenterprise.com/sessions/c203f91a88cf43afa7c9de7b5f5f84d2
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/c203f91a88cf43afa7c9de7b5f5f84d2?variant=devin
Requested by: @kwent