Repository navigation
Use ruby's Gem::Version instead of npm's semver to parse rubygems version - #946
Merged
Merged
Conversation
ntkme
commented
Oct 9, 2026
ntkme
commented
Collaborator
- Fixes Can't install prerelease RubyGems #945
ntkme
force-pushed
the
gem-version
branch
2 times, most recently
from
October 9, 2026 19:08
a86e223 to
907bc9a
Compare
Collaborator
Author
|
@enebo Can you please review this when you have a chance? |
eregon
approved these changes
Oct 19, 2026
| async function compareGemVersion(a, b, rubyPrefix) { | ||
| const ruby = path.join(rubyPrefix, 'bin', 'ruby') | ||
|
|
||
| const { stdout } = await exec.getExecOutput(ruby, ['-e', 'puts Gem::Version.new(ARGV[0]) <=> Gem::Version.new(ARGV[1])', '--', a, b]) |
Member
There was a problem hiding this comment.
Calling ruby an extra time for this might take some time, OTOH updating RubyGems is not super fast so this seems fine.
| "@actions/io": "^2.0.0", | ||
| "@actions/tool-cache": "^3.0.0", | ||
| "linux-os-info": "^2.0.0", | ||
| "semver": "^7.7.3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.