Skip to content

CLDSRV-1045: Name only the requested key ARN when rejecting a key from an unconfigured KMS - #6337

Open
dvasilas wants to merge 2 commits into
development/9.6from
improvement/CLDSRV-1045-name-only-requested-key-arn
Open

dvasilas wants to merge 2 commits into
development/9.6from
improvement/CLDSRV-1045-name-only-requested-key-arn

Conversation

@dvasilas

@dvasilas dvasilas commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Bump Arsenal so the rejection of a key from an unconfigured KMS names only the requested ARN (scality/Arsenal#2738), and pass that ARN at both checks.

@dvasilas
dvasilas added this pull request to stack #6336 October 21, 2026 07:32
@codecov

codecov Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
19136 1 19135 955
View the top 1 failed test(s) by shortest run time
quota evaluation with scuba metrics::should allow a restore if the quota is full but the objet fits with its reserved storage space
Stack Traces | 30s run time
Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (.../tests/sur/quota.js)
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (.../tests/sur/quota.js)
    at listOnTimeout (node:internal/timers:685:17)
    at process.processTimers (node:internal/timers:618:7)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

Base automatically changed from improvement/CLDSRV-1030-route-keys-to-their-kms to development/9.6 October 22, 2026 06:33
@bert-e

bert-e commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Hello dvasilas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/bypass_source_branch_lineage Bypass the cross-branch contamination check ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request.
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Conflict

There is a conflict between your branch improvement/CLDSRV-1045-name-only-requested-key-arn and the
destination branch development/9.6.

Please resolve the conflict on the feature branch (improvement/CLDSRV-1045-name-only-requested-key-arn).

git fetch && \
git checkout origin/improvement/CLDSRV-1045-name-only-requested-key-arn && \
git merge origin/development/9.6

Resolve merge conflicts and commit

git push origin HEAD:improvement/CLDSRV-1045-name-only-requested-key-arn

@dvasilas
dvasilas force-pushed the improvement/CLDSRV-1045-name-only-requested-key-arn branch from 47f55ec to 89187d5 Compare October 22, 2026 08:05
@bert-e

bert-e commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Comment thread lib/kms/wrapper.js
…m an unconfigured KMS

Pass the requested key ARN to Arsenal at both checks.
@dvasilas
dvasilas force-pushed the improvement/CLDSRV-1045-name-only-requested-key-arn branch from 89187d5 to 4be78a8 Compare October 22, 2026 10:12

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants