Repository navigation
Conversation
Base URLs for OpenAI and Anthropic backends no longer store the API version suffix. The version is now owned by the backend, which exposes an `api_version` attribute and an `api_base_url` property that joins the base URL with the version when building requests. This keeps stored configuration version agnostic and makes it possible to support other API versions (or version discovery) without reconfiguring backends. Added `strip_api_version`, `normalize_backend_base_url` and `normalize_global_config_base_urls` helpers in the common config module. Loading the global configuration now migrates legacy versioned base URLs in place and persists the normalized values back to disk. The interactive config editor and the backend creation prompt also strip any version suffix the user enters. Tests updated and extended to cover the new helpers and the split between `base_url` and `api_base_url`. Assisted-by: claude-opus-5 Signed-off-by: Simo Sorce <simo@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Base URLs for OpenAI and Anthropic backends no longer store the API version suffix. The version is now owned by the backend, which exposes an
api_versionattribute and anapi_base_urlproperty that joins the base URL with the version when building requests. This keeps stored configuration version agnostic and makes it possible to support other API versions (or version discovery) without reconfiguring backends.Added
strip_api_version,normalize_backend_base_urlandnormalize_global_config_base_urlshelpers in the common config module. Loading the global configuration now migrates legacy versioned base URLs in place and persists the normalized values back to disk. The interactive config editor and the backend creation prompt also strip any version suffix the user enters.Tests updated and extended to cover the new helpers and the split between
base_urlandapi_base_url.Assisted-by: claude-opus-5