Skip to content

fix(oauth): save installer-latest in FileInstallationStore when historical data is disabled #1986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
abhishekacharya200 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(oauth): save installer-latest in FileInstallationStore when historical data is disabled #1986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions slack_sdk/oauth/installation_store/file/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,14 @@ def save(self, installation: Installation):
f.write(entity)

else:
# per workspace
entity = json.dumps(installation.__dict__)
with open(f"{team_installation_dir}/installer-latest", "w") as f:
f.write(entity)

# per workspace per user
u_id = installation.user_id or none
installer_filepath = f"{team_installation_dir}/installer-{u_id}-latest"
with open(installer_filepath, "w") as f:
entity = json.dumps(installation.__dict__)
with open(f"{team_installation_dir}/installer-{u_id}-latest", "w") as f:
f.write(entity)

def save_bot(self, bot: Bot):
Expand Down
29 changes: 29 additions & 0 deletions tests/slack_sdk/oauth/installation_store/test_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import tempfile
import unittest

from slack_sdk.oauth.installation_store import Installation, FileInstallationStore
Expand Down Expand Up @@ -78,6 +79,34 @@ def test_save_and_find(self):
bot = store.find_bot(enterprise_id="E111", team_id="T222")
self.assertIsNone(bot)

def test_save_and_find_without_historical_data(self):
with tempfile.TemporaryDirectory() as base_dir:
store = FileInstallationStore(base_dir=base_dir, client_id="111.222", historical_data_enabled=False)
installation = Installation(
app_id="A111",
enterprise_id="E111",
team_id="T111",
user_id="U111",
bot_id="B111",
bot_token="xoxb-111",
bot_scopes=["chat:write"],
bot_user_id="U222",
)
store.save(installation)

bot = store.find_bot(enterprise_id="E111", team_id="T111")
self.assertIsNotNone(bot)

i = store.find_installation(enterprise_id="E111", team_id="T111")
self.assertIsNotNone(i)
self.assertEqual(i.bot_token, "xoxb-111")
i = store.find_installation(enterprise_id="E111", team_id="T111", user_id="U111")
self.assertIsNotNone(i)

store.delete_installation(enterprise_id="E111", team_id="T111")
i = store.find_installation(enterprise_id="E111", team_id="T111")
self.assertIsNone(i)

def test_org_installation(self):
store = FileInstallationStore(client_id="111.222")
installation = Installation(
Expand Down