Repository navigation
Conversation
klpoland
added
feature
klpoland
marked this pull request as ready for review
October 20, 2026 19:46
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
klpoland
force-pushed
the
feature-kpoland-federation-peer-registry
branch
from
October 21, 2026 15:51
372beda to
71c3e32
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.
There are 3 total unresolved issues (including 1 from previous review).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 4329ab5. Configure here.
mjcurran
approved these changes
Oct 21, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
High Risk
Touches federation trust boundaries (signed manifests, dynamic peers, mothership verify with outbound HTTPS) and new intake flows that gate who can join the mesh; misconfiguration could widen peer sets or break sync bootstrap.
Overview
Adds an end-to-end federation registry path: gateways advertise identity at
/.well-known/sds-federation.json, the flagship host exposes logged-in registry intake (apply, one-time challenge token, domain verify, staff approve/reject, reissue/withdraw), and the federation sync service can pull a signedsites.jsonmanifest, verify it with Ed25519, and merge registry peers with pinnedfederation.tomlpeers on a refresh loop (bootstrapping new peers and exposingGET /sync/api/v1/sites).Gateway: new
RegistryApplicationmodel and UI under/users/federation/registry/(404 on non-flagship hosts even if env says intake on). Verify fetches applicant well-known over HTTPS with DNS pinning / SSRF guards (local lab can use internal HTTP for same-FQDN). Well-known JSON can includeregistry_challengefromFEDERATION_REGISTRY_CHALLENGE_TOKENplus optional registry URL/fingerprint fields. Settings addSDS_SITE_DISPLAY_NAME, flagship gating viaFLAGSHIP_GATEWAY_HOST, and related federation env docs.Federation:
federation-add-peer --discoverreads peer well-known;RegistryPolicyin config;site_registryhandles signature, serial monotonicity, cache fallback, deny list, and runtime peer snapshots used across webhooks/bootstrap.cryptographyadded for manifest verification.Docs/README and example env templates are updated for discover, registry verify, and intake flags.
Reviewed by Cursor Bugbot for commit 213dec8. Bugbot is set up for automated code reviews on this repo. Configure here.