Skip to content

fix(modal) :: apply height to the model's content - #1585

Open
81reap wants to merge 1 commit into
mainfrom
81reap/issue/1046
Open

81reap wants to merge 1 commit into
mainfrom
81reap/issue/1046

Conversation

@81reap

@81reap 81reap commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

The height of the modal component sets the height of its content. Overflow content scrolls.

Fixes #1046

Assisted-By :: Claude Opus 5.5

The `height` of the modal component sets the height of its content. Overflow content scrolls.

Fixes #1046

Assisted-By :: Claude Opus 5.5
@81reap
81reap force-pushed the 81reap/issue/1046 branch from 70f9a9e to d2280a0 Compare October 30, 2026 22:57
@81reap

81reap commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author
$ cat tests/end-to-end/fixtures/repro_1046/index.sql
SELECT 'button' AS component;
SELECT 'Open' AS title, 'tall' AS modal;
SELECT 'modal' AS component, 'tall' AS id, 'Tall modal' AS title, 500 AS height;
SELECT 'A short text in a tall modal' AS contents;

$ cat tests/end-to-end/fixtures/repro_1046/test.ts
import { expect, test } from "../../fixture.ts";

test("height sets the height of a modal without an embed", async ({ page }) => {
  await page.getByRole("button", { name: "Open" }).click();
  const content = page.locator("#tall .modal-body > .card");
  await expect(content).toBeVisible();
  expect((await content.boundingBox())?.height).toBe(500);
});
repro_1046 sqlite
v0.37.0 ✘ failed
v0.47.0 ✘ failed
tree ✔ passed

On commit d2280a0: nix run .#reproduce -- repro_1046 sqlite v0.37.0 v0.47.0 tree

@81reap
81reap marked this pull request as ready for review October 30, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Modal and height variable

2 participants