Repository navigation
Conversation
The `height` of the modal component sets the height of its content. Overflow content scrolls. Fixes #1046 Assisted-By :: Claude Opus 5.5
81reap
force-pushed
the
81reap/issue/1046
branch
from
October 30, 2026 22:57
70f9a9e to
d2280a0
Compare
Collaborator
Author
$ cat tests/end-to-end/fixtures/repro_1046/index.sql
SELECT 'button' AS component;
SELECT 'Open' AS title, 'tall' AS modal;
SELECT 'modal' AS component, 'tall' AS id, 'Tall modal' AS title, 500 AS height;
SELECT 'A short text in a tall modal' AS contents;
$ cat tests/end-to-end/fixtures/repro_1046/test.ts
import { expect, test } from "../../fixture.ts";
test("height sets the height of a modal without an embed", async ({ page }) => {
await page.getByRole("button", { name: "Open" }).click();
const content = page.locator("#tall .modal-body > .card");
await expect(content).toBeVisible();
expect((await content.boundingBox())?.height).toBe(500);
});
On commit d2280a0: |
81reap
marked this pull request as ready for review
October 30, 2026 23:17
lovasoa
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
heightof the modal component sets the height of its content. Overflow content scrolls.Fixes #1046
Assisted-By :: Claude Opus 5.5