Repository navigation
feat(card) :: let a card's link open a new tab - #1586
Merged
Merged
Conversation
Each card accepts a `target`, such as `_blank`, for its link. It works like the button component's `target`. Fixes #820 Assisted-By :: Claude Opus 5.5
Collaborator
Author
$ cat tests/end-to-end/fixtures/repro_820/index.sql
SELECT 'card' AS component;
SELECT 'Other app' AS title, 'https://example.com' AS link, '_blank' AS target;
$ cat tests/end-to-end/fixtures/repro_820/test.ts
import { expect, test } from "../../fixture.ts";
test("a card link can open in a new tab", async ({ page }) => {
await expect(page.getByRole("link", { name: "Other app" })).toHaveAttribute("target", "_blank");
});
On commit fab7df1: |
|
This comment will be updated automatically if new data arrives. 🔗 Commit SHA: fab7df1 | Docs | View more details | Give us feedback! |
81reap
marked this pull request as ready for review
October 31, 2026 00:49
Collaborator
Author
|
CI failed for unrelated reasons, requested rerun and it passed |
Collaborator
|
Why is our ci flaky? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each card accepts a
target, such as_blank, for its link. It works like the button component'starget.Fixes #820
Assisted-By :: Claude Opus 5.5