Skip to content

feat(card) :: let a card's link open a new tab - #1586

Merged
lovasoa merged 1 commit into
mainfrom
81reap/issue/820
Oct 31, 2026
Merged

lovasoa merged 1 commit into
mainfrom
81reap/issue/820

Conversation

@81reap

@81reap 81reap commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

Each card accepts a target, such as _blank, for its link. It works like the button component's target.

Fixes #820

Assisted-By :: Claude Opus 5.5

Each card accepts a `target`, such as `_blank`, for its link. It works like the button component's `target`.

Fixes #820

Assisted-By :: Claude Opus 5.5
@81reap

81reap commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator Author
$ cat tests/end-to-end/fixtures/repro_820/index.sql
SELECT 'card' AS component;
SELECT 'Other app' AS title, 'https://example.com' AS link, '_blank' AS target;

$ cat tests/end-to-end/fixtures/repro_820/test.ts 
import { expect, test } from "../../fixture.ts";

test("a card link can open in a new tab", async ({ page }) => {
  await expect(page.getByRole("link", { name: "Other app" })).toHaveAttribute("target", "_blank");
});
repro_820 sqlite
v0.33.0 ✘ failed
v0.47.0 ✘ failed
tree ✔ passed

On commit fab7df1: nix run .#reproduce -- repro_820 sqlite v0.33.0 v0.47.0 tree

@datadog-official

datadog-official Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Pipelines

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: fab7df1 | Docs | View more details | Give us feedback!

@81reap
81reap marked this pull request as ready for review October 31, 2026 00:49
@81reap

81reap commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator Author

CI failed for unrelated reasons, requested rerun and it passed

@lovasoa

lovasoa commented Oct 31, 2026

Copy link
Copy Markdown
Collaborator

Why is our ci flaky?

@lovasoa
lovasoa added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 321ad21 Oct 31, 2026
108 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

in the card component, can we add a new row level parameter that lets us choose if the clickable link can be opened in a new tab ?

2 participants