Repository navigation
refactor(config): cover the rest of config/src with effect lint (CLI-2756) - #7263
Merged
7ttp merged 1 commit intoOct 21, 2026
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 AI Review
Confirmed Claude’s single naming nit. Codex reported no findings, and the adjudication pass found no additional issues. Tests and type checks were not run because dependencies are absent.
Findings
| Severity | Location | Category | Sources | Claim |
|---|---|---|---|---|
| ⚪ NIT | packages/config/src/project-config/project-schema.unit.test.ts:37 |
naming |
claude | legacyFixturePath now names an Effect that resolves a path, but its name still suggests a plain path string. |
Stats
Claude findings: 1 · Codex findings: 0 · Confirmed: 1 · Refuted: 0 · Uncertain: 0
Models: claude-opus-5-5 + gpt-6.1-sol · Trigger: auto · Workflow run
This review runs once per PR. A maintainer can request another with a /ai-review comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
brings the rest of
packages/config/srcunder the effect lintwhats introduced?
packages/config/src/**joins the allow list, and theschema-numbermodules stay out until the schema fix on topproject.tsyields its parse error directly instead of throughEffect.fail./iomethods are plain promise returning functions behindEffect.suspendinstead ofasync, so they resolve and reject exactly as before and never throw synchronously, onlyisAsyncFunctionflipsFileSystem, skipping entries that vanish mid scanref