Skip to content

Soundness: add additional tool arguments input to API breakage check - #324

Merged
FranzBusch merged 1 commit into
mainfrom
bkhouri/main/soudness_api_diff_support_additional_tool_args
Oct 20, 2026
Merged

FranzBusch merged 1 commit into
mainfrom
bkhouri/main/soudness_api_diff_support_additional_tool_args

Conversation

@bkhouri

@bkhouri bkhouri commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Add the api_breakage_check_additional_tool_arguments input to the Soundness workflow. Its value is appended to the swift package diagnose-api-breaking-changes invocation, with or without --breakage-allowlist-path.

This lets callers pass any flag the tool supports (for example, --products) without needing a dedicated workflow input for each one.

The input defaults to an empty string, so existing callers see no change in behavior.

Relates to: swiftlang/swift-package-manager#9394

@bkhouri
bkhouri requested a review from a team as a code owner October 16, 2026 06:21
@bkhouri
bkhouri added this pull request to stack #326 October 16, 2026 06:21
Comment thread .github/workflows/soundness.yml Outdated
Add the `api_breakage_check_additional_tool_arguments` input to the
Soundness workflow. Its value is appended to the
`swift package diagnose-api-breaking-changes` invocation, with or
without `--breakage-allowlist-path`.

This lets callers pass any flag the tool supports (for example,
`--products`) without needing a dedicated workflow input for each one.

The input defaults to an empty string, so existing callers see no
change in behavior.

Relates to: swiftlang/swift-package-manager#9394
@bkhouri
bkhouri force-pushed the bkhouri/main/soudness_api_diff_support_additional_tool_args branch from ba0d29a to 070a06b Compare October 20, 2026 12:54
@FranzBusch
FranzBusch merged commit f2b93cf into main Oct 20, 2026
193 of 196 checks passed
@FranzBusch
FranzBusch deleted the bkhouri/main/soudness_api_diff_support_additional_tool_args branch October 20, 2026 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants