Skip to content

Return None for an unset expiration_time in ActivityHandle.describe() #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LindseyZ1205 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return None for an unset expiration_time in ActivityHandle.describe() #2016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/fixed/timeless-tortoise.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`ActivityHandle.describe()` now returns `None` as the `expiration_time` of a Standalone Activity that has no schedule-to-close timeout, instead of a naive `datetime.min`.
2 changes: 1 addition & 1 deletion temporalio/client/_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ def _from_resp(
expiration_time=(
resp.info.expiration_time.ToDatetime(tzinfo=timezone.utc)
if resp.info.HasField("expiration_time")
else datetime.min
else None
),
heartbeat_timeout=(
resp.info.heartbeat_timeout.ToTimedelta()
Expand Down
17 changes: 17 additions & 0 deletions tests/test_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,23 @@ async def test_describe(self, client: Client, activity_handle: ActivityHandle):
assert desc.next_attempt_schedule_time is None
assert desc.retry_policy is not None

async def test_describe_without_schedule_to_close_timeout(
self, client: Client, env: WorkflowEnvironment, task_queue: str
):
if env.supports_time_skipping_v1:
pytest.skip(
"Java test server: https://github.com/temporalio/sdk-java/issues/2741"
)
activity_handle = await client.start_activity(
heartbeat_fail_increment,
args=(1,),
id=str(uuid.uuid4()),
task_queue=task_queue,
start_to_close_timeout=timedelta(minutes=1),
)
desc = await activity_handle.describe()
assert desc.expiration_time is None # no schedule-to-close timeout

async def test_describe_payloads(
self, client: Client, activity_handle: ActivityHandle, task_queue: str
):
Expand Down
Loading