Repository navigation
fix: TanStack apps get no Next.js views from make:resource - #17
Merged
Merged
Conversation
fadymondy
changed the title
…nstall is skipped - make:resource wrote web/app/<table>/page.tsx and swr hooks under web/lib into TanStack Router apps, which render resources through the generic /admin/<table> route. When the web app is TanStack (src/router.tsx or vite.config.ts), make:resource skips the view layer and points at /admin/<table>; make:view and make:page say so instead of writing files. Next.js apps are unchanged. - The npm shim downloads the binary on first run when the postinstall never ran (npm --ignore-scripts or an allow-scripts gate that blocks), instead of exiting with "binary not found".
fadymondy
force-pushed
the
fix/shorts-bugs
branch
from
October 13, 2026 15:38
f785f2b to
3c41b8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug from the v0.2.33 shorts recording: make:resource writes a Next.js page into a TanStack app.
generator.TanStackFrontenddetects the TanStack/Vite frontend (web/src/router.tsxorweb/vite.config.ts).web/app/<table>/page.tsx, swr hooks and API client underweb/lib) and printspage: /admin/<table>, which the generic admin renders.TestMakeResourceViewsFollowFrontend(tanstack + nextjs) andTestTanStackFrontend.togo new --frontend tanstackapp: noweb/apporweb/lib, and the REST handler is still generated.The npm install mechanism is deliberately left unchanged (decision 8cc7eb28).