Repository navigation
fix(new): treat redirected stdin as non-interactive - #18
Merged
Merged
Conversation
isInteractive() checked os.ModeCharDevice, which is also set for /dev/null and NUL, so 'togo new --db postgres </dev/null' still offered and ran 'docker compose up -d'. Use term.IsTerminal like internal/ui does. Fixes #4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4
isInteractive()usedos.ModeCharDevice, which is also set for/dev/nullandNUL. It now usesterm.IsTerminal(int(os.Stdin.Fd())), matchinginternal/ui. With redirected stdin,togo newno longer prompts for features/frontend/database and no longer offers or runsdocker compose up -d; it uses the defaults and the flags.Test:
TestIsInteractive_RedirectedStdin(devnull/NUL, regular file, pipe) failed before the change and passes now.go vet ./...andgo test ./...pass.🤖 Generated with Claude Code