Repository navigation
fix(npm): enforce LF line endings and guard the packed tarball - #19
Merged
Merged
Conversation
Add .gitattributes (* text=auto eol=lf) so checkouts are LF regardless of core.autocrlf, and an npm pack test that fails if any packed file contains a CR byte. The test runs in the npm CI job on ubuntu and windows. Fixes #9 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
.gitattributeswith* text=auto eol=lf(plus binary markers), sonpm/is LF on every checkout whatevercore.autocrlfis.git ls-files --eol npm/showsw/lfafter this.npm/pack.test.js: runsnpm pack, extracts the tarball and fails if any file contains a CR byte. It also has a unit check showing a CRLF file is flagged. I verified locally that the test fails with a CRLFbin/togo.jsand passes with LF. It is not published (not infiles).npmjob (ubuntu + windows) now runs it.Not done here: moving
npm publishinto the tag-triggered release workflow (item 2 of the issue). That needs an npm token and a decision about provenance/approval, so npm publishing stays a manual maintainer step for now. 0.2.33 is not republished; the next npm release is the first to carry the guard.🤖 Generated with Claude Code