Repository navigation
feat: add snapToPoint prop for custom snap behavior - #887
Merged
Merged
Conversation
Allows callers to override the built-in snap logic with their own function, called with (value, snapPoints, snapTolerance) for each pane size during drag. Only invoked when snapPoints is non-empty; defaults to the behavior when omitted.
# Conflicts: # src/hooks/useResizer.test.ts
Since tomkp#888, snapping applies to the pane before the dragged divider and the next pane absorbs the difference, so the custom function is called once per move rather than once per pane.
Owner
|
Thanks! I merged master in and updated one test: since #888, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for not opening an issue on this first - I needed it anyways as a local patch, so I though I'd just directly open a PR. :)
This allows userland to override default
snapToPointbehavior - in our case, we had a sidebar that should snap closed beyond a certain size and back to open when dragged sufficiently far, but not snap to "minimal open width" when the cursor was coming to "minimal open width" from the right, only from the left.