Repository navigation
fix: keep preventDefault working in the legacy mouse/touch bridge - #890
Merged
Merged
Conversation
Spreading a React SyntheticEvent only copies own properties, so preventDefault and stopPropagation were dropped. The synthetic events might not have real pointer IDs, so guard against `setPointerCapture` throwing.
The legacy onMouseDown/onTouchStart bridge gave drags a made-up pointerId
(1 for mouse, touch.identifier for touch). Real pointer events rarely
match it, so those drags never moved and, now that preventDefault works,
never ended either, leaving the divider stuck in its dragging state.
- Bridged drags start without a pointerId and adopt the first primary
pointer that follows.
- Ignore a second start while a drag is in progress. Dividers that spread
{...props} get both onPointerDown and onTouchStart, so a finger fired
pointerdown then touchstart and the second start hijacked the drag.
Owner
|
Thanks for this, and sorry for the slow response! The While testing I found two more problems in the same bridge, so I've pushed a commit on top of yours:
I dropped the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the "styled" example wasn't working - looks like it probably broke with #879.