Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #86 +/- ##
==========================================
+ Coverage 99.40% 99.42% +0.01%
==========================================
Files 9 9
Lines 336 345 +9
Branches 38 40 +2
==========================================
+ Hits 334 343 +9
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response::Assembly#cancel!currently sends an unsigned DELETE, so cancellation fails for Workspaces that require correct signatures.Responses returned by
Assembly#create!,get, andreplayretain their originating client. Cancellation includes its auth parameters and signs with its secret when configured; each signed cancellation receives a fresh nonce. Authentication survives response replacement and reloads. Directly constructed responses without a client preserve their existing unsigned behavior.Validation: full Ruby 3.3 suite passes (128 tests, 265 assertions; optional live-upload and signature-parity tests skipped), plus
bundle exec standardrbandgit diff --check. Tests check the actual outgoing HMAC for created and fetched Assemblies, replayed responses, fresh nonces, and clients without a secret. Existing direct-response cancellation coverage also passes.Compatibility: constrain JSON to versions below 3 because Ruby 3.1 resolves MultiJson 1.19, whose positional parsing options are incompatible with JSON 3. This dependency constraint is shared across the four independent fixes.
The four fixes also merge together cleanly. Their combined Ruby 3.3 suite passes with Node signature parity enabled: 147 tests, 321 assertions, with only the optional live upload skipped.
Also make the existing rate-limit warning assertion tolerate unrelated dependency deprecation messages. The Ruby 3.4 CI seed that exposed it (30047) passes locally after the assertion change.