Repository navigation
fix(release): publish GitHub release only after assets and checksums are verified - #262
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
None. No sql-pipe issue tracks this change; it implements the shared release contract planned in vmvarela/ghoten#238.
What
Release workflow now stages the GitHub release as a draft and publishes it only after every asset, package and checksum is in place. Native binaries are checked against
sha256sums.txtbefore publication. Downstream channels (npm, Homebrew, AUR, WinGet, Scoop, Nix, APT, RPM, APK) run after publication instead of before. NetBSD targets are removed from the matrix until their Zig 0.17 link failure is fixed.Why
The previous flow made the release public before packages and checksums existed, and allowed publication after a build failure (
always()). Consumers could see an incomplete release, and channels could update from it.How tested
git diff --check, YAML parse, andactionlint -shellcheck=pass. Shellcheck warnings already present in the originalchecksumsstep are unchanged.Remaining work
x86_64-netbsd,aarch64-netbsd) must be restored once the__ssp_protected_*link failure with Zig 0.17 is fixed.publish-releasepublishes it again.publish-releasedoes not setmake_latestor checktarget_commitish.0.99.0.test.2) and APK (0.99.0_test.2).Definition of Done
zig buildpasses): not applicable, no Zig code changed