Repository navigation
feat(tracing): mark invocation spans as ERA roots - #1195
Merged
yaozheng-fang merged 2 commits intoNov 2, 2026
Merged
Conversation
yaozheng-fang
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VeADK invocation spans now receive
era.span_type="root"when they start, so APMPlus can identify the invocation entrypoint before a model response is available. The marker is retained through cloud export even when local span retention is disabled. Agent and LLM child spans remain unmarked.This is an additive telemetry attribute on the existing invocation-name branch, including invocations with an upstream parent. It does not change public Python signatures, configuration, or span parentage. The schema-v2
invoke_workflowentrypoint is outside this change.Validation on 2026-11-02, against base
65f30f28and the final two-file runtime/test diff:uv run --locked --extra dev --extra codex pytest tests/test_tracing.py tests/test_tracing_content.py tests/test_model_timing.py tests/config/test_tracing_config.py -q— 89 tests.uv run --locked --extra dev --extra codex pre-commit run --all-files— Ruff, formatting, secret scans, and dependency policy.era.span_type=rootoninvocationwith no marker on the three child spans. The smoke used synthetic user/session identifiers and disabled content collection. Credentials and cloud evidence are kept out of this PR.git diff --check.uv run --locked --extra dev pytest -n 2 -m "not codex_smoke and not piagent_smoke"— 7,913 passed, 17 failed, 63 skipped, 4 xfailed. Rerunning those 17 tests from an isolated working directory with thecodexextra installed yielded 15 passed and 2 failed. Both remaining failures reproduce on an unmodified archive of65f30f28: platform.mdMIME detection and a machine-global Git ignore rule affecting the sandbox-upload test fixture. No global configuration or test expectations were changed to bypass these failures.The full regression suite is therefore not claimed to pass. Live verification covers the default ADK invocation path; external runtime smoke tests were not run.