Repository navigation
Hold algorithm-list names to RFC 4251 format - #1321
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1321
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 4 in-scope changed file(s) opened by the reviewer; not opened: wolfssh/internal.h, wolfssh/ssh.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
CheckAlgoList() skips unknown names, but the setters keep the caller's string and SendKexInit() sends it verbatim. Every name in the list now has to be at most 64 bytes of printable US-ASCII with no space and at most one '@', not first or last, per RFC 4251 Section 6 and RFC 4250 Section 4.6, or the setter returns WS_INVALID_ALGO_ID. - internal.h: add WOLFSSH_MAX_ALGO_NAME_SZ for the 64-byte cap - api.c: cover the 64/65-byte bound, space, tab, DEL, high bytes, the at-sign count and an at-sign at either end - ssh.h: state the name format in the setter contract Issue: F-15529
ejohnstown
force-pushed
the
algo-list-setters
branch
from
October 16, 2026 17:24
e39ff3f to
446bfda
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1321
Scan targets checked: none
Unchanged since last review (not re-run): wolfssh-src, wolfssh-bugs
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SetAlgoList*setters skip unknown names but keep the caller's string, and KEXINIT sends it verbatim. Every name in the list must now be well formed (RFC 4251 section 6, RFC 4250 section 4.6), or the setter returnsWS_INVALID_ALGO_ID.@, not first or lasttests/api.ccovers the 64/65-byte bound, each banned byte class, and the@count and positionIssue: F-15529