Repository navigation
docs: fix Python SDK build status badge - #756
Merged
Merged
Conversation
Contributor
[Low impact] The PR is safe to merge, but restoring the build-status badge would fulfill its stated purpose. Findings
Fix with agent prompt### Issue 1
README.md:4
The latest change deletes the working GitHub Actions badge instead of replacing the obsolete Semaphore badge as described. Readers of `README.md` can no longer see the build status or open the CI workflow. Restore the GitHub Actions badge and link scoped to `main`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryRemoves the obsolete Semaphore badge from
Reviews (2) · Last reviewed commit: "Remove build status badge from README" · Reviewed by Greptile |
Removed build status badge from README.md
Contributor
|
executive decision: deleting the badge. never really liked these. like, we're not going to check in a version of this code that obviously breaks main. |
|
|
||
|  | ||
| [](https://workos.semaphoreci.com/projects/workos-python) | ||
|
|
Contributor
There was a problem hiding this comment.
The latest change deletes the working GitHub Actions badge instead of replacing the obsolete Semaphore badge as described. Readers of README.md can no longer see the build status or open the CI workflow. Restore the GitHub Actions badge and link scoped to main.
Prompt To Fix With AI
This is a comment left during a code review.
Path: README.md
Line: 4
Comment:
**Build status is missing**
The latest change deletes the working GitHub Actions badge instead of replacing the obsolete Semaphore badge as described. Readers of `README.md` can no longer see the build status or open the CI workflow. Restore the GitHub Actions badge and link scoped to `main`.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes DOC-639.
Replace the obsolete Semaphore build-status image and link in
README.mdwith the repository's GitHub Actions CI badge and workflow page, both scoped tomain. The broken Semaphore image is also embedded under WorkOS Python Library on the Python SDK docs page.Documentation
This is a one-line README correction, not an SDK behavior change. The source badge is fixed here; the live docs page has not been updated or deployed by this PR.
Validation
naturalWidth === 0, while the adjacent PyPI badge loads.branch:mainfiltering.git diff --checkpasses.Visual verification
The README at commit
2f91321984410707e889f00c2ba7f2254af2ac6frenders the new badge successfully (naturalWidth: 90,naturalHeight: 20). This screenshot is from the changed README on GitHub, not a production docs deployment.Requested by kathleen.brandt@workos.com (best-known issue attribution; workflow execution, no employee action authority) in Linear