Repository navigation
Install the SQLite command-line tool in the Docker workers - #414
Conversation
The database commands export and import SQLite databases through it, and the GitHub-hosted runners have it as well. The SQLite built for older PHP images installs a matching one already. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Install SQLite CLI utils/docker/Dockerfile |
The apt package list now includes sqlite3. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix
Possibly related issues
- Run Behat in throwaway containers when Docker is available #391 — The issue concerns declared test requirements in containers; this change installs the SQLite executable.
- Declare and check the external tools that scenarios need #393 — The issue concerns missing external tools; this change adds
sqlite3to the Docker image. - Report scenarios that are filtered out by unmet requirements #392 — The issue concerns unmet CI and container requirements; this change supplies the SQLite executable.
- Epic: Explicit test requirements #395 — The issue concerns missing external tools for tests; this change installs
sqlite3.
Possibly related PRs
- wp-cli/wp-cli-tests#413 — This PR also changes SQLite support in the Dockerfile, including a conditional SQLite build.
Suggested labels: bug, scope:testing, scope:artifacts
Suggested reviewers: brianhenryie
Merge Risk: 
Minimal · up to 20e5e
-
No actionable merge-blocking risk was identified in this Docker package change.
Pre-merge checks: 
5
-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Follow-up to #408 and #413.
wp db exportandwp db import(and a few other db-command scenarios) call thesqlite3command-line tool for SQLite databases. The GitHub-hosted runners have it, the Docker image did not, so every SQLite job of db-command failed when running in Docker containers, with errors like:This installs the
sqlite3package. Images of PHP 8.0 and older already get a matchingsqlite3from the SQLite built in #413, which comes first in thePATH.Testing
sqlite33.46.1) and 7.4 (/usr/local/bin/sqlite33.54.1).Summary by CodeRabbit