Repository navigation
feat(matricole): align Matricole with the shared layout; fix CardIcon responsive sizes - #209
Draft
viganogabriele wants to merge 2 commits into
Draft
viganogabriele wants to merge 2 commits into
viganogabriele wants to merge 2 commits into
Conversation
CardIcon's responsive `size` ({ base, sm, md, lg }) builds "sm:…" classes at
runtime, so Tailwind never generated the ones not written literally elsewhere
(e.g. sm:px-8 for the homepage material shortcuts). Generate every prefixed
variant of the size maps with @source inline(), and add a test that fails if
classes.ts gains a class missing from that list.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rids - Hero, sections and FAQ use the shared container, hero offset, rhythm and section titles; the featured resources close the hero. - "Guide e Utility" is a section title (it was 22px on phones, smaller than the Telegram Hub card title) and sits closer to its own content. - Large resource cards: descriptions capped at 448px instead of 240px. - The large guide sits beside the 2x2 small guides only from xl, on a 5/7 split repeated by Materiali / Tech Tools, so "Mappa Microonde" no longer wraps; the four small guides use 20px titles. - Telegram Hub: two columns until xl (four columns clipped "Mercatino" at 1024px); the group has 24px padding on phones instead of 48px, so its links span the width as in the Figma mobile frame. - Resources with a link react to hover, the others don't. - Resources hidden on phones stay hidden: that's the Figma mobile frame, an open design decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #208 (
/groups) → … → #199 (homepage). Merge in order. Two commits: a shared CardIcon fix and the/matricolepage.Figma: desktop
3222:8274, mobile3351:13333. The page was already faithful to Figma on desktop. This PR brings it onto the layout the other redesigned pages share, and fixes the widths Figma doesn't cover.1.
fix(card-icon): responsive sizes were never generatedCardIconaccepts a responsivesize({ base, sm, md, lg }). The prefixed classes (sm:px-8,lg:h-44…) were built at runtime incard-icon/utils.ts. Tailwind never saw them in the source, so any variant not written literally elsewhere was silently missing.globals.cssgenerates every prefixed variant of theclasses.tsmaps with@source inline("{sm:,md:,lg:}{…}"). The runtime API is unchanged.tests/card-icon-classes.test.mjsfails ifclasses.tsgains a class that is missing from that list.sm:px-8(12 → 32 px horizontal padding). Their labels are centred, so nothing moves; at 640 px the 128 px label still fits the 169 px tile./storiaproject list resolves to the same values it had before./,/storia,/groupsand/guidesat 390, 768 and 1440 px have identical page heights.2.
feat(matricole)Layout
CONTAINER,PAGE_HERO,PAGE_MAINandSECTION_TITLEfromlayout/page.ts, like the other redesigned pages. The hero uses the sharedHero.Headings
Cards and grids
xl, on a 5/7 split. At 1:1 "Mappa Microonde" wrapped at 1280–1440 px.inline-sm).xlthe large guide spans the width, with the small ones in 2×2 underneath.xl; four columns clipped "Mercatino" and wrapped "Consigli PC" at 1024 px.CardGroupis only used on this page.Interaction
Content source
/matricolereads fromweb.freshman.getContent(#193), which isn't reachable locally.Screenshots
Backend unavailable (real state, no fixture):
Verification
pnpm check: clean.pnpm build: passes.pnpm typecheck: passes.node --test tests/*.test.mjs: 3/3 pass, including the new test.Trade-offs
Deliberately left out
h2via the sharedHero, like every other page, because the header logo is theh1site-wide. Fixing the heading outline is a separate cross-page change.Housekeeping
Screenshots live on
pr-assets/matricole-visual-refinement, which can be deleted after review.🤖 Generated with Claude Code