Repository navigation
feat(faqs): open on a non-empty category and tighten the FAQ layout - #211
Open
viganogabriele wants to merge 1 commit into
Open
viganogabriele wants to merge 1 commit into
viganogabriele wants to merge 1 commit into
Conversation
- Default to the first category that has answers: live data opens on "Generale", which is empty, so the page showed a blank band. - Empty categories show an intentional dashed empty state instead of nothing; answers keep the editors' line breaks. - Shared container and hero rhythm; the tabs follow the hero closely (they are its content, not a new section) and the list column is Figma's 900px; the callout sits 64/96px under the list instead of 272/316px. - Phones: the tab strip bleeds to the screen edges, the callout title is readable (14px instead of 11px). - Accordion (shared with /matricole and /guides): answers capped at ~70 characters per line, only the header reacts to hover, 2px focus ring. - Tabs (shared with /storia): hover tint on inactive tabs, focus ring. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This was referenced Oct 28, 2026
viganogabriele
marked this pull request as ready for review
October 31, 2026 17:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/faqsfollows Figma (2334:5376desktop,2611:5646mobile) closely in structure. The problems were in the states the frames don't show and in the spacing around the list.What changes
An empty first tab no longer blanks the page
/projectsand/associations: "Non ci sono ancora domande in questa categoria."Layout and rhythm
CONTAINERandPAGE_HERO/PAGE_MAINfromlayout/page.ts, replacing the oldpx-4 py-49withjustify-center.md. They are the hero's content, not a new section, so they don't get the post-hero break. Figma leaves about 100 px.Phones
label-small), which was too small to read.Answers
whitespace-pre-line).Shared changes and their reach
AccordionContent:max-w-[70ch],text-pretty/matricoleFAQ,/guidesAccordionTrigger: hover tint on the header only, inset 2 pxblue-secondaryfocus ringAccordionItem:overflow-hiddenso the header tint follows the rounded cornersTabsTrigger: white tint on hover for inactive tabs, inset focus ring (resolves the TODO in the file)/storia(boards, thanks)CalloutItemtitle 14 px on phones/faqs/storiaand/guides/generali, before and after at 390 and 1440 px, have identical page heights.Screenshots
The backend isn't reachable locally, so before and after use the same temporary, uncommitted fixture:
1440, default tab (before: the empty "Generale")

1440 and 1024, "Lezioni" tab


390


Empty category and tab hover; accordion header hover and keyboard focus


Verification
pnpm check: clean.pnpm build: passes.pnpm typecheck: clean.node --test tests/*.test.mjs: 3/3 pass./faqsin the browser at 320, 390, 768, 1024, 1279, 1280, 1440, 1728 and 1920 px; there is no horizontal overflow at any width.Trade-offs
/guidesaccordions, which currently show placeholder content.Deliberately left out
FaqSelector_Desktop(2962:9615) is an unimplemented design exploration.Housekeeping
Screenshots live on
pr-assets/faqs-visual-refinement, so this diff stays code-only. That branch can be deleted after review.🤖 Generated with Claude Code