Raise the PostgreSQL floor to 12 and add GitHub Actions CI with update testing by jnasbyupgrade · Pull Request #4 · Postgres-Extensions/trunklet-format

jnasbyupgrade · 2026-10-25T19:13:10Z

Raises the supported PostgreSQL floor to 12 and replaces Travis with GitHub Actions CI. On every supported major, CI tests both a fresh install and the update from 0.2.0.

The floor is 12 because extension_drop pulls in cat_tools, and cat_tools 0.3.0 and newer declare PostgreSQL 12 as their minimum (on 9.6, creating it fails with syntax error at or near "ROUTINE"). This PR raises the PostgreSQL build prereq in META.in.json to 12.0.0, adds a HISTORY.asc entry, and removes the test/deps.sql setup code that only ran before PostgreSQL 10.

Update testing

make test-update (make test TEST_LOAD_SOURCE=update) runs the same suite against the same expected output. Instead of installing the current version, pg_temp._create() in test/deps.sql installs 0.2.0 and runs ALTER EXTENSION "trunklet-format" UPDATE. It creates extension_drop first, as updating from 0.2.0 requires. The mode reaches the tests as a placeholder GUC (trunklet_format.test_load_mode) through PGOPTIONS, and _create() fails if the GUC is missing or holds an unknown value. With the function replacement removed from sql/trunklet-format--0.2.0--stable.sql, make test-update fails.

CI

.github/workflows/ci.yml has three jobs:

A changes job that skips the test matrix on docs-only pushes and derives the PostgreSQL major list from NEWEST and FLOOR.
A per-major job in the pgxn/pgxn-tools container that runs make verify-results, then make verify-results TEST_LOAD_SOURCE=update.
A single all-checks-passed job for branch protection.

Run 40407837451 passes on PostgreSQL 12 through 18, with both test steps green on each major.

Also removes the Travis configuration (.travis.yml, pg-travis-test.sh), which tested only PostgreSQL 9.5 and 9.6, along with test comments that referred to Travis or to PostgreSQL 10. The DETAIL checks in test/sql/base.sql that were disabled because they did not work on Travis are re-enabled as pgTAP assertions.

🤖 Generated with Claude Code

coderabbitai · 2026-10-25T19:13:18Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 564226cf-93cb-40af-a06b-527ff168275e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Adds `.github/workflows/ci.yml`: a changes job that skips the test matrix on docs-only pushes and derives the supported PostgreSQL major list from one pair of constants, a per-major test job in the `pgxn/pgxn-tools` container that runs `make verify-results`, and a single `all-checks-passed` job for branch protection. Removes the Travis configuration (`.travis.yml`, `pg-travis-test.sh`), which tested only PostgreSQL 9.5 and 9.6. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Matches the final trunklet CI workflow: supported range is PostgreSQL 9.5 through 18, with 9.6 and 9.5 listed explicitly because `seq` can't express them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

extension_drop installs cat_tools >= 0.2.1, which now resolves to cat_tools 0.3.0; that release requires PostgreSQL 12 and fails to install on older majors. Set the PostgreSQL build prereq to 12.0.0, make the CI matrix a plain range from NEWEST down to FLOOR=12, and drop the test setup code that only ran before PostgreSQL 10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

`make test-update` (TEST_LOAD_SOURCE=update) runs the same suite with the same expected output, but pg_temp._create() installs 0.2.0 and runs ALTER EXTENSION UPDATE instead of installing the current version. It creates extension_drop first, since 0.2.0 did not require it. CI runs it as a second step in each test job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

jnasbyupgrade · 2026-10-26T21:26:20Z

  ) specifier_test
 ;
-- This is meant to ensure the DETAIL is correct, but it doesn't work on travis :(
+-- Disabled check that the DETAIL is correct


Uh... can we actually test this now?

Claude here: flagged for review.

Claude here: re-enabled both DETAIL checks as pgTAP assertions in a9f969f. A pg_temp helper captures the exception DETAIL and is() compares it to parameter "<name>" at template position <N> for all three templates; they all pass.

Replace the commented-out psql-based DETAIL checks in base.sql with a pg_temp helper that captures PG_EXCEPTION_DETAIL, asserted with is(). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jnasbyupgrade added this pull request to stack #5 October 25, 2026 19:13

jnasbyupgrade marked this pull request as draft October 25, 2026 19:16

jnasbyupgrade force-pushed the ci-workflow branch from fa35b1d to e2486ed Compare October 25, 2026 19:27

jnasbyupgrade changed the title ~~Replace Travis with GitHub Actions CI~~ CI: Replace Travis with GitHub Actions CI Oct 25, 2026

jnasbyupgrade force-pushed the ci-workflow branch from e2486ed to 789b597 Compare October 25, 2026 19:38

jnasbyupgrade mentioned this pull request Oct 25, 2026

CI: Add RELEASE.md for trunklet-format release specifics #1

Merged

jnasbyupgrade removed this pull request from stack #5 October 25, 2026 19:47

jnasbyupgrade force-pushed the ci-workflow branch from 789b597 to 7f24f9b Compare October 25, 2026 19:47

jnasbyupgrade added this pull request to stack #7 October 25, 2026 19:47

This was referenced Oct 25, 2026

Adapt to pgxntool 2.4.0 and fix tests for current PostgreSQL #3

Merged

Switch master to the stable pseudo-version and restore the shipped 0.2.0 script #8

Merged

jnasbyupgrade removed this pull request from stack #7 October 25, 2026 20:10

jnasbyupgrade added this pull request to stack #9 October 25, 2026 20:10

jnasbyupgrade changed the title ~~CI: Replace Travis with GitHub Actions CI~~ Raise the PostgreSQL floor to 12 and add GitHub Actions CI with update testing Oct 25, 2026

Base automatically changed from pgxntool-update to master October 26, 2026 21:17

jnasbyupgrade and others added 6 commits October 26, 2026 16:17

Derive the PostgreSQL major list from NEWEST/FLOOR plus a 9.x tail

57dd240

Matches the final trunklet CI workflow: supported range is PostgreSQL 9.5 through 18, with 9.6 and 9.5 listed explicitly because `seq` can't express them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Note the PostgreSQL 12 floor in HISTORY and drop stale comments

3c0b6fe

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Keep the update-from version only in the Makefile; README floor to 12

ae26503

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

jnasbyupgrade force-pushed the ci-workflow branch from b5a63e8 to ae26503 Compare October 26, 2026 21:17

jnasbyupgrade marked this pull request as ready for review October 26, 2026 21:18

jnasbyupgrade commented Oct 26, 2026

View reviewed changes

jnasbyupgrade and others added 2 commits October 26, 2026 16:32

Re-enable DETAIL checks as pgTAP assertions

8dc22b5

Replace the commented-out psql-based DETAIL checks in base.sql with a pg_temp helper that captures PG_EXCEPTION_DETAIL, asserted with is(). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

Simplify DETAIL assertions: helper takes the template, single is() call

a9f969f

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jnasbyupgrade merged commit 9474269 into master Oct 26, 2026
10 checks passed

jnasbyupgrade deleted the ci-workflow branch October 26, 2026 22:39

Navigation Menu

Repository navigation

Raise the PostgreSQL floor to 12 and add GitHub Actions CI with update testing - #4

Raise the PostgreSQL floor to 12 and add GitHub Actions CI with update testing#4
jnasbyupgrade merged 8 commits into
masterfrom
ci-workflow

jnasbyupgrade commented Oct 25, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading

Review skipped

Uh oh!

jnasbyupgrade Oct 26, 2026

Uh oh!

jnasbyupgrade Oct 26, 2026

Uh oh!

jnasbyupgrade Oct 26, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jnasbyupgrade commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Update testing

CI

Uh oh!

coderabbitai Bot commented Oct 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

jnasbyupgrade Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

jnasbyupgrade Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

jnasbyupgrade Oct 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jnasbyupgrade commented Oct 25, 2026 •

edited

Loading

coderabbitai Bot commented Oct 25, 2026 •

edited

Loading