Repository navigation
fix(social): read-only face rooms hide the composer, readable own handle, no Friends' Bots wording (#197) - #211
Conversation
…dle, no Friends' Bots wording (ThinkFlowLab#197)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b68ca02af4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .fs-refresh{flex:none;font-size:11px;line-height:14px;color:var(--bt-ink-3,rgba(20,20,20,.36));font-weight:400} | ||
| .fs-room-end{margin:6px 12px;padding:8px 10px;border-radius:8px;background:var(--bt-hover,rgba(119,119,119,.09));color:var(--bt-ink-2,rgba(20,20,20,.6));font-size:12px;line-height:16px} | ||
| /* A left or closed face room is read-only (#197): its end line replaces the composer. */ | ||
| [class*="_composerStack"]:has([data-flybot="face-room-end"]) [class*="_root"]:has(> [data-composer-card]){display:none!important} |
There was a problem hiding this comment.
Update the social subsystem doc or add the waiver
When checked against this commit's parent, cd core && ARCH_DOCS_BASE=129752c^ node scripts/check-arch-docs.mjs fails: these plugins/social/ edits are owned by docs/subsystems/social.md, but the commit changes neither that page nor includes a Docs-not-needed: trailer. Since npm run lint runs this gate, required CI cannot pass for this commit; document the changed UI contract or add the trailer if it is truly docs-neutral.
AGENTS.md reference: AGENTS.md:L94-L94
Useful? React with 👍 / 👎.
Refs #197 (items 2, 4, 5). Items 1, 3 and 6 stay open, see below.
Fixed
--bt-inkat 13px instead of--bt-ink-2at 12px.relationship_existsmessage (client and host) now says "You're already friends. Their Bot is back in your list." The held-message notice to a friend's Bot no longer points to a Friends' Bots section and names the setting the UI really shows: "Sent, but it waits for your approval in this chat. Turn on Auto-send for this friend to skip that next time." (It said "Auto-accept" before.) The small marker label "Friend's Bot" stays, as it names the Bot, not a section.Not in this PR
pastFaceRoomsandsocial/face-roomsreturns it on the next 5 s poll, so the cause is not visible from code. Needs a live repro (one guess to check: the slowpollFaceRooms()call to Bot Social blocking the reply).Ran:
ARCH_DOCS_BASE=upstream/main npm run verifywithTZ=UTCon Node 24: pass (core 750, social 161, tree 56, scripts 56, interop). New test#197: …inplugins/social/test/social.test.js. Changelog fragmentchangelog.d/197-social-ui-nits.fixed.md.Not run: browser check of the CSS rule (it relies on DSH's
_composerStack/_root+[data-composer-card]markup, the same hookscore/src/client/styles.jsalready uses).