Skip to content

fix(social): read-only face rooms hide the composer, readable own handle, no Friends' Bots wording (#197) - #211

Merged
Birfy merged 2 commits into
ThinkFlowLab:mainfrom
Birfy:fix197-social-nits
Oct 17, 2026
Merged

Birfy merged 2 commits into
ThinkFlowLab:mainfrom
Birfy:fix197-social-nits

Conversation

@Birfy

@Birfy Birfy commented Oct 17, 2026

Copy link
Copy Markdown
Collaborator

Refs #197 (items 2, 4, 5). Items 1, 3 and 6 stay open, see below.

Fixed

  • Composer under a read-only past room (item 2). When a face-to-face room is left or closed, its "You left this room." / "… left the room. This room is closed." line already sits in the composer stack; a CSS rule now hides the message box whenever that line is shown. Open rooms are unchanged.
  • Own handle contrast (item 4). The account-menu handle uses --bt-ink at 13px instead of --bt-ink-2 at 12px.
  • "Friends' Bots" wording (item 5). The relationship_exists message (client and host) now says "You're already friends. Their Bot is back in your list." The held-message notice to a friend's Bot no longer points to a Friends' Bots section and names the setting the UI really shows: "Sent, but it waits for your approval in this chat. Turn on Auto-send for this friend to skip that next time." (It said "Auto-accept" before.) The small marker label "Friend's Bot" stays, as it names the Bot, not a section.

Not in this PR

  • Item 1 (Past rooms stale until reload): the host already moves a left room to pastFaceRooms and social/face-rooms returns it on the next 5 s poll, so the cause is not visible from code. Needs a live repro (one guess to check: the slow pollFaceRooms() call to Bot Social blocking the reply).
  • Item 3 (+ menu shown as a "New… ×" tab): needs the compact popover rework from Social UI polish round 3: truncation, duplicate Add friend/Accept invite, Manage access depth, wording (#166 follow-up) #173.
  • Item 6 (Chief greeting in Chinese): the kickoff already says "Write in English" when no locale was reported, and the client reports the active DSH locale; needs a live repro to tell a model slip from a zh locale.

Ran: ARCH_DOCS_BASE=upstream/main npm run verify with TZ=UTC on Node 24: pass (core 750, social 161, tree 56, scripts 56, interop). New test #197: … in plugins/social/test/social.test.js. Changelog fragment changelog.d/197-social-ui-nits.fixed.md.
Not run: browser check of the CSS rule (it relies on DSH's _composerStack / _root + [data-composer-card] markup, the same hooks core/src/client/styles.js already uses).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 17, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-17T16:27:22.374374Z b68ca02 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Birfy
Birfy added this pull request to the merge queue Oct 17, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b68ca02af4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread plugins/social/client.js
.fs-refresh{flex:none;font-size:11px;line-height:14px;color:var(--bt-ink-3,rgba(20,20,20,.36));font-weight:400}
.fs-room-end{margin:6px 12px;padding:8px 10px;border-radius:8px;background:var(--bt-hover,rgba(119,119,119,.09));color:var(--bt-ink-2,rgba(20,20,20,.6));font-size:12px;line-height:16px}
/* A left or closed face room is read-only (#197): its end line replaces the composer. */
[class*="_composerStack"]:has([data-flybot="face-room-end"]) [class*="_root"]:has(> [data-composer-card]){display:none!important}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the social subsystem doc or add the waiver

When checked against this commit's parent, cd core && ARCH_DOCS_BASE=129752c^ node scripts/check-arch-docs.mjs fails: these plugins/social/ edits are owned by docs/subsystems/social.md, but the commit changes neither that page nor includes a Docs-not-needed: trailer. Since npm run lint runs this gate, required CI cannot pass for this commit; document the changed UI contract or add the trailer if it is truly docs-neutral.

AGENTS.md reference: AGENTS.md:L94-L94

Useful? React with 👍 / 👎.

Merged via the queue into ThinkFlowLab:main with commit 35e1366 Oct 17, 2026
6 checks passed
@Birfy
Birfy deleted the fix197-social-nits branch October 17, 2026 16:28
@Birfy Birfy mentioned this pull request Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant