Skip to content

turbovla: f16 weights and flash attention by default on SYCL #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sandlbn wants to merge 1 commit into
base: main
Choose a base branch
from
Open

turbovla: f16 weights and flash attention by default on SYCL #58

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/models/turbovla.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -770,6 +770,20 @@ std::unique_ptr<ModelArchBase> turbovla_create(const std::string& mmproj_path,
if (!b.handle)
return nullptr;
m->backend = b.handle;
// On SYCL, F16-resident weights and flash attention (oneDNN's fused SDPA)
// unless --weight-dtype / --flash-attn say otherwise: 2 views at 256 px go
// from 128 to 74 ms on a Core Ultra 7 356H, with the actions within 3.4e-4
// of the F32 graph (BF16 weights: 70 ms, but 2.9e-3).
if (b.is_sycl) {
if (!opts.weight_dtype) {
m->mt = GGML_TYPE_F16;
std::printf("vla(turbovla): weights = f16 (SYCL default; --weight-dtype f32 to keep them f32)\n");
}
if (!opts.flash_attn.has_value() && fa_takes_views()) {
set_flash_attn(true);
std::printf("vla(turbovla): flash attention = on (SYCL default; --flash-attn 0 to disable)\n");
}
}

if (!load_weights(*m, g) || !m->upload_rope_tables())
return nullptr;
Expand Down
Loading