Repository navigation
contrib/kcp: generate bootstrap APIBinding permission claims in a loop - #654
Open
NopeCharon wants to merge 1 commit into
Open
NopeCharon wants to merge 1 commit into
NopeCharon wants to merge 1 commit into
Conversation
bindAPIExport spelled out every accepted permission claim of the
kube-bind.io APIBinding as a fully nested AcceptablePermissionClaim
literal. All thirteen entries were identical apart from the group and
resource: every one grants all verbs ("*"), matches all objects and is
in the Accepted state. That made the list ~200 lines long and hard to
review or extend.
Keep only the claimed GroupResources in a package-level
acceptedPermissionClaims list and build the AcceptablePermissionClaims
from it in a loop. The resulting APIBinding spec is unchanged: the same
claims are produced in the same order with the same verbs, selector and
state.
Fixes kbind-dev#286
Signed-off-by: NopeCharon <115794254+NopeCharon@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bindAPIExportincontrib/kcp/deploy/bootstrap.gospelled out each of the 13 accepted permission claims of thekube-bind.ioAPIBinding as a fully nestedAcceptablePermissionClaimliteral. The entries only differed in group/resource: all of them use verbs*,MatchAll: trueand stateAccepted.This PR follows the suggestion from the review discussion linked in the issue and keeps only the claimed
GroupResources in anacceptedPermissionClaimslist, building the claims from it in a loop (~190 fewer lines).The generated APIBinding spec does not change. I checked this with a throwaway test against the kcp fake clientset: the claims produced by the new code are
reflect.DeepEqualto the old literal, with the same 13 entries in the same order.go vetandgolangci-lint(repo config) pass forcontrib/kcp/deploy.What Type of PR Is This?
/kind cleanup
Related Issue(s)
Fixes #286
Release Notes