Skip to content

contrib/kcp: generate bootstrap APIBinding permission claims in a loop #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NopeCharon wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −188
Open

contrib/kcp: generate bootstrap APIBinding permission claims in a loop #654

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
211 changes: 23 additions & 188 deletions contrib/kcp/deploy/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,24 @@ import (
//go:embed examples/*.yaml
var Examples embed.FS

// acceptedPermissionClaims are the resources whose permission claims are accepted, with
// all verbs on all objects, when binding the kube-bind.io APIExport.
var acceptedPermissionClaims = []apisv1alpha2.GroupResource{
{Group: "rbac.authorization.k8s.io", Resource: "clusterrolebindings"},
{Group: "rbac.authorization.k8s.io", Resource: "clusterroles"},
{Group: "rbac.authorization.k8s.io", Resource: "roles"},
{Group: "rbac.authorization.k8s.io", Resource: "rolebindings"},
{Group: "", Resource: "serviceaccounts"},
{Group: "", Resource: "configmaps"},
{Group: "", Resource: "secrets"},
{Group: apisv1alpha2.SchemeGroupVersion.Group, Resource: "apiexports"},
{Group: "apiextensions.k8s.io", Resource: "customresourcedefinitions"},
{Group: "", Resource: "namespaces"},
{Group: "apis.kcp.io", Resource: "apiresourceschemas"},
{Group: "apis.kcp.io", Resource: "apibindings"},
{Group: "authorization.k8s.io", Resource: "subjectaccessreviews"},
}

// Bootstrap creates resources in this package by continuously retrying the list.
// This is blocking, i.e. it only returns (with error) when the context is closed or with nil when
// the bootstrapping is successfully completed.
Expand Down Expand Up @@ -83,202 +101,19 @@ func bindAPIExport(ctx context.Context, kcpClient kcpclient.Interface, exportNam
},
}

binding.Spec.PermissionClaims = []apisv1alpha2.AcceptablePermissionClaim{
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "rbac.authorization.k8s.io",
Resource: "clusterrolebindings",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "rbac.authorization.k8s.io",
Resource: "clusterroles",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "rbac.authorization.k8s.io",
Resource: "roles",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "rbac.authorization.k8s.io",
Resource: "rolebindings",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "",
Resource: "serviceaccounts",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "",
Resource: "configmaps",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
for _, gr := range acceptedPermissionClaims {
binding.Spec.PermissionClaims = append(binding.Spec.PermissionClaims, apisv1alpha2.AcceptablePermissionClaim{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "",
Resource: "secrets",
},
Verbs: []string{"*"},
GroupResource: gr,
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: apisv1alpha2.SchemeGroupVersion.Group,
Resource: "apiexports",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "apiextensions.k8s.io",
Resource: "customresourcedefinitions",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "",
Resource: "namespaces",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "apis.kcp.io",
Resource: "apiresourceschemas",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "apis.kcp.io",
Resource: "apibindings",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
{
ScopedPermissionClaim: apisv1alpha2.ScopedPermissionClaim{
PermissionClaim: apisv1alpha2.PermissionClaim{
GroupResource: apisv1alpha2.GroupResource{
Group: "authorization.k8s.io",
Resource: "subjectaccessreviews",
},
Verbs: []string{"*"},
},
Selector: apisv1alpha2.PermissionClaimSelector{
MatchAll: true,
},
},
State: apisv1alpha2.ClaimAccepted,
},
})
}

_, err := kcpClient.ApisV1alpha2().APIBindings().Create(ctx, binding, metav1.CreateOptions{})
Expand Down