Repository navigation
chore: bump gradle-wrapper from 8.5 to 9.8.2 in /android - #460
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [gradle-wrapper](https://github.com/gradle/gradle) from 8.5 to 9.8.2. - [Release notes](https://github.com/gradle/gradle/releases) - [Commits](gradle/gradle@v8.5.0...v9.8.2) --- updated-dependencies: - dependency-name: gradle-wrapper dependency-version: 9.8.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.5-all.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-9.8.2-all.zip |
There was a problem hiding this comment.
🔴 After merging, every ./gradlew run in /android, local or in CI, will likely fail during configuration. Before this change it ran on Gradle 8.5. The new wrapper points at Gradle 9.8.2. But android/build.gradle:8 still pins AGP com.android.tools.build:gradle:8.1.4, which predates Gradle 9 and is not supported on it. Gradle 9 removed APIs that old AGP versions rely on. Fix: either keep the wrapper on 8.x, or in the same change raise AGP to a Gradle 9-compatible release (8.4 or later per Gradle's compatibility notes). Then check that KGP 2.1.0, ktlint 14.2.0 and kotlinOptions still configure.
Why this was flagged
The trigger is any Gradle invocation through the wrapper. CI runs ./gradlew test, lint, ktlintCheck and assembleDebug in .github/workflows/pull-request.yml:69,81,93,126, and cd android && ./gradlew test in release-publish.yml:47. The diff changes distributionUrl to gradle-9.8.2-all.zip but touches no build files. android/build.gradle:8 still puts AGP 8.1.4 on the buildscript classpath. That AGP release targets Gradle 8.0–8.x, and Gradle 9 removed deprecated APIs that pre-8.4 AGP uses (for example the Convention API). Applying com.android.library (build.gradle:45) is therefore expected to fail at configuration time. That would break the Android unit-test, lint, ktlint and assemble CI jobs and the release-publish test step, all of which pass on the base with Gradle 8.5. No version check or fallback in the repo blocks this, because the wrapper picks the Gradle version on its own.
Verification: The diff changes only android/gradle/wrapper/gradle-wrapper.properties:6 (gradle-8.5-all.zip -> gradle-9.8.2-all.zip), the wrapper jar and the scripts. android/build.gradle is not touched, and line 8 still has classpath 'com.android.tools.build:gradle:8.1.4'. Gradle's compatibility notes only cover AGP 8.4 and later on Gradle 9. In practice, CI on the base branch runs Gradle 8.5 with AGP 8.1.4, which is a supported pair.
Bumps gradle-wrapper from 8.5 to 9.8.2.
Release notes
Sourced from gradle-wrapper's releases.
... (truncated)
Commits
8de7bcfSpeed up the AllVersionsCrossVersion flaky quarantine (#39494)66805dbRun all cross-version targets in flaky quarantinecdd4c8fSkip empty test tasks in the flaky test quarantine6badb77Split the AllVersionsCrossVersion quarantine across agents1655e44Prepare for 9.8.2 (#39492)6702214Prepare for 9.8.2688c0c1Fix false warning about unstable graph (#39479)3601d4fClarify selector reuse comments in SelectorState6e836fdFix false warning about unstable grapha0790e5Fix hidden artifact cleanup pattern in CheckProject (#39451)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)