Repository navigation
chore: bump gradle-wrapper from 8.5 to 9.8.2 in /android #460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dependabot
wants to merge
1
commit into
main
Choose a base branch
from
dependabot/gradle/android/gradle-wrapper-9.8.2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 After merging, every
./gradlewrun in /android, local or in CI, will likely fail during configuration. Before this change it ran on Gradle 8.5. The new wrapper points at Gradle 9.8.2. But android/build.gradle:8 still pins AGPcom.android.tools.build:gradle:8.1.4, which predates Gradle 9 and is not supported on it. Gradle 9 removed APIs that old AGP versions rely on. Fix: either keep the wrapper on 8.x, or in the same change raise AGP to a Gradle 9-compatible release (8.4 or later per Gradle's compatibility notes). Then check that KGP 2.1.0, ktlint 14.2.0 andkotlinOptionsstill configure.Why this was flagged
The trigger is any Gradle invocation through the wrapper. CI runs
./gradlew test,lint,ktlintCheckandassembleDebugin .github/workflows/pull-request.yml:69,81,93,126, andcd android && ./gradlew testin release-publish.yml:47. The diff changes distributionUrl to gradle-9.8.2-all.zip but touches no build files. android/build.gradle:8 still puts AGP 8.1.4 on the buildscript classpath. That AGP release targets Gradle 8.0–8.x, and Gradle 9 removed deprecated APIs that pre-8.4 AGP uses (for example the Convention API). Applyingcom.android.library(build.gradle:45) is therefore expected to fail at configuration time. That would break the Android unit-test, lint, ktlint and assemble CI jobs and the release-publish test step, all of which pass on the base with Gradle 8.5. No version check or fallback in the repo blocks this, because the wrapper picks the Gradle version on its own.Verification: The diff changes only android/gradle/wrapper/gradle-wrapper.properties:6 (
gradle-8.5-all.zip->gradle-9.8.2-all.zip), the wrapper jar and the scripts. android/build.gradle is not touched, and line 8 still hasclasspath 'com.android.tools.build:gradle:8.1.4'. Gradle's compatibility notes only cover AGP 8.4 and later on Gradle 9. In practice, CI on the base branch runs Gradle 8.5 with AGP 8.1.4, which is a supported pair.