Skip to content

fix(helpscout): require explicit tags to clear, validate custom field entries and positive IDs, and correct trigger and credential copy - #9271

Merged
waleedlatif1 merged 3 commits into
stagingfrom
fix/helpscout-release-review
Oct 21, 2026
Merged

waleedlatif1 merged 3 commits into
stagingfrom
fix/helpscout-release-review

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Set Conversation Tags no longer wipes every tag when tags is omitted: the param is required (and required in the block for that operation), and [] is the explicit way to remove every tag
  • Update Custom Fields rejects non-object entries like [null] with the tool's validation error instead of a raw TypeError
  • Help Scout IDs must be positive and canonical (no 0, no leading zeros); one parseIdText check now backs the tools, selector, webhook handler, and connector instead of four copies
  • Trigger person outputs (assignee, createdBy, primaryCustomer) document their fields, including name
  • Agent Replied trigger copy says "an agent replies"
  • Help Scout app-credential guidance moves to the App ID field hint, since the connect modal only renders helpText under an orgId field; documented that on the descriptor type
  • Addresses the Help Scout review threads on the v0.9.30 release PR

Type of Change

  • Bug fix

Testing

  • lib/webhooks/providers/helpscout.test.ts and blocks/blocks.test.ts pass
  • Exercised the tags, custom-field, ID, and created-webhook-ID parsers directly against the edge cases (omitted/empty/[]/JSON tags, [null], 0, 007, unsafe integers, Resource-ID vs Location)
  • lint, block-registry check, unused-exports check; regenerated tool metadata and integration docs

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

… entries and positive IDs, and correct trigger and credential copy
@vercel

vercel Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 21, 2026 4:14am UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/helpscout/set-conversation-tags.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 14 files

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

Comment thread apps/sim/tools/helpscout/set-conversation-tags.ts Outdated
@greptile-apps

greptile-apps Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; both previous tag-parsing issues are fixed.

Summary

This PR makes tag clearing explicit, shares positive-ID checks across Help Scout code, rejects invalid custom-field entries, and corrects setup and trigger descriptions.

  • Set Conversation Tags needs an explicit tag list to change a conversation's tags.
  • Help Scout entry points accept only positive, canonical IDs.
  • Update Custom Fields checks each entry before using it.
  • Help Scout triggers and credential setup show clearer details.

Reviews (3) · Last reviewed commit: "fix(helpscout): keep bracketed tags on t..." · Reviewed by Greptile

Comment thread apps/sim/tools/helpscout/set-conversation-tags.ts Outdated
Comment thread apps/sim/tools/helpscout/set-conversation-tags.ts Outdated
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 6511ea4 into staging Oct 21, 2026
45 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/helpscout-release-review branch October 21, 2026 04:23

This branch was previously deployed

1 inactive deployment
Preview — c307e6dc Deployed Oct 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant