Repository navigation
fix(helpscout): require explicit tags to clear, validate custom field entries and positive IDs, and correct trigger and credential copy - #9271
Conversation
… entries and positive IDs, and correct trigger and credential copy
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Turn on auto-fix | Re-trigger cubic
|
@greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
|
@greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 14 files
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Turn on auto-fix | Re-trigger cubic
[Medium impact] The PR appears safe to merge; both previous tag-parsing issues are fixed. SummaryThis PR makes tag clearing explicit, shares positive-ID checks across Help Scout code, rejects invalid custom-field entries, and corrects setup and trigger descriptions.
Reviews (3) · Last reviewed commit: "fix(helpscout): keep bracketed tags on t..." · Reviewed by Greptile |
…lear only on a literal []
|
@greptile |
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
No issues found across 14 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Heads up: you’re close to your flex budget. Increase your flex budget so reviews don’t pause.
Turn on auto-fix | Re-trigger cubic
Summary
tagsis omitted: the param is required (and required in the block for that operation), and[]is the explicit way to remove every tag[null]with the tool's validation error instead of a raw TypeError0, no leading zeros); oneparseIdTextcheck now backs the tools, selector, webhook handler, and connector instead of four copiesnamehelpTextunder anorgIdfield; documented that on the descriptor typeType of Change
Testing
lib/webhooks/providers/helpscout.test.tsandblocks/blocks.test.tspass[]/JSON tags,[null],0,007, unsafe integers, Resource-ID vs Location)Checklist
test-auditauthoring gate)